bryanck commented on code in PR #6707:
URL: https://github.com/apache/iceberg/pull/6707#discussion_r1091447817
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Util.java:
##########
@@ -354,10 +354,10 @@ public static class AuthSession {
private static int tokenRefreshNumRetries = 5;
Review Comment:
This could be volatile also. Maybe make `refresh()` below synchronized as
well? It should only be called by the schedule thread but might make sense to
be on the safe side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
