RussellSpitzer commented on code in PR #6682:
URL: https://github.com/apache/iceberg/pull/6682#discussion_r1095005897
##########
api/src/main/java/org/apache/iceberg/actions/DeleteOrphanFiles.java:
##########
@@ -67,7 +67,11 @@ public interface DeleteOrphanFiles extends
Action<DeleteOrphanFiles, DeleteOrpha
*
* @param deleteFunc a function that will be called to delete files
* @return this for method chaining
+ * @deprecated Deletes are now performed in bulk see {@link
#deleteBulkWith(Consumer)}. This
Review Comment:
One of my goals here is to remove those existing apis. I feel like custom
delete function here is solely here for testing. Any user who actually wants to
deal with their results would use the "toDataframe" option for Spark.
Currently we have too many options here and no real use cases. This really
shouldn't be a set of configuration or options that users should be concerned
with. If they are, the correct spot to be modifying this is the FileIO. For
example, if I have multiple actions running at the same time, the coordination
of requests to S3 or whatnot should happen at the FileIO, otherwise the user
needs to manually be determining the correct values for each of their possible
concurrent jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
