danielcweeks commented on code in PR #6598: URL: https://github.com/apache/iceberg/pull/6598#discussion_r1096213570
########## api/src/main/java/org/apache/iceberg/view/SQLViewRepresentation.java: ########## @@ -18,14 +18,17 @@ */ package org.apache.iceberg.view; +import edu.umd.cs.findbugs.annotations.Nullable; Review Comment: Nullable annotations have been used in puffin and metrics, but I do think we should standardize on `javax.annotation.Nullable` as opposed to this findbugs version if we are going to be explicit about nullability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
