danielcweeks commented on code in PR #6740:
URL: https://github.com/apache/iceberg/pull/6740#discussion_r1096956705
##########
snowflake/src/main/java/org/apache/iceberg/snowflake/SnowflakeCatalog.java:
##########
@@ -45,6 +45,7 @@ public class SnowflakeCatalog extends BaseMetastoreCatalog
implements Closeable, SupportsNamespaces, Configurable<Object> {
private static final String DEFAULT_CATALOG_NAME = "snowflake_catalog";
private static final String DEFAULT_FILE_IO_IMPL =
"org.apache.iceberg.io.ResolvingFileIO";
+ private static final String APP_IDENTIFIER = "iceberg-SDK";
Review Comment:
I don't feel like this identifier makes a lot of sense. What is the `SDK`
in this context? The snowflake catalog isn't an SDK, so I'm not sure what this
is intended to convey.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
