szehon-ho commented on code in PR #6661:
URL: https://github.com/apache/iceberg/pull/6661#discussion_r1103059479
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -236,5 +273,17 @@ void update(DataFile file) {
this.fileCount += 1;
this.specId = file.specId();
}
+
+ void update(DeleteFile file) {
+ if (file.content() == FileContent.POSITION_DELETES) {
+ this.posDeleteRecordCount += file.recordCount();
Review Comment:
Yea that's not there yet. Let me refer to @aokolnychyi @RussellSpitzer to
see which is better here, maybe going with a set is the only approach for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
