danielcweeks commented on code in PR #6811:
URL: https://github.com/apache/iceberg/pull/6811#discussion_r1103864436
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -235,16 +236,18 @@ public String toString() {
private final List<SortOrder> sortOrders;
private final Map<String, String> properties;
private final long currentSnapshotId;
- private final List<Snapshot> snapshots;
- private final Map<Long, Snapshot> snapshotsById;
private final Map<Integer, Schema> schemasById;
private final Map<Integer, PartitionSpec> specsById;
private final Map<Integer, SortOrder> sortOrdersById;
private final List<HistoryEntry> snapshotLog;
private final List<MetadataLogEntry> previousFiles;
- private final Map<String, SnapshotRef> refs;
private final List<StatisticsFile> statisticsFiles;
private final List<MetadataUpdate> changes;
+ private final SerializableSupplier<List<Snapshot>> snapshotsSupplier;
+ private List<Snapshot> snapshots;
Review Comment:
Ok, I've updated to be `volatile` and `ensureSnapshotsLoaded` should be
synchronized to make it thread safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
