zhongyujiang commented on code in PR #6836:
URL: https://github.com/apache/iceberg/pull/6836#discussion_r1105779788
##########
parquet/src/test/java/org/apache/iceberg/parquet/TestDictionaryRowGroupFilter.java:
##########
@@ -1030,7 +1030,7 @@ public void testMissingDictionaryPageForColumn() {
IllegalStateException.class,
"Failed to read required dictionary page for id: 5",
() ->
- new ParquetDictionaryRowGroupFilter(SCHEMA, notEqual("some_nulls",
"some"))
+ new ParquetDictionaryRowGroupFilter(SCHEMA, equal("some_nulls",
"some"))
Review Comment:
The old UT will fail after this change because `notEq` will not try to read
the dictionary when there may exist null values. Fixed it by using `eq` as the
predicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
