jackye1995 commented on code in PR #6828:
URL: https://github.com/apache/iceberg/pull/6828#discussion_r1106037265
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java:
##########
@@ -228,6 +228,16 @@ private DistributionMode
adjustWriteDistributionMode(DistributionMode mode) {
}
}
+ private DistributionMode defaultDistributionMode() {
+ if (table.sortOrder().isSorted()) {
+ return RANGE;
+ } else if (table.spec().isPartitioned()) {
+ return HASH;
+ } else {
+ return NONE;
Review Comment:
> What about exploring this separately?
+1, the benefit seems to be not so straightforward to cluster by all
columns. We can first have this generic default and then make more changes for
unpartitioned case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
