RussellSpitzer commented on code in PR #6801:
URL: https://github.com/apache/iceberg/pull/6801#discussion_r1106380719
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRewriteDataFilesProcedure.java:
##########
@@ -230,8 +266,14 @@ public void
testRewriteDataFilesWithFilterOnPartitionTable() {
assertEquals(
"Action should rewrite 5 data files from single matching partition"
+ "(containing c2 = bar) and add 1 data files",
- ImmutableList.of(row(5, 1)),
- output);
+ row(5, 1),
+ Arrays.copyOf(output.get(0), 2));
+ // verify rewritten bytes separately
+ assertThat(output.get(0)).hasSize(3);
+ assertThat(output.get(0)[2])
+ .asInstanceOf(InstanceOfAssertFactories.LONG)
+ .isGreaterThan(0L)
+ .isLessThan(dataSizeBefore);
Review Comment:
I think you can just check the Snapshot summary? Would that give us the
right value?
I'm also wondering if we need this AssertThat syntax, can we just do
Assert.assertEquals? Or are there benefits i'm missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
