[GitHub] [iceberg] nastra commented on a diff in pull request #6799: Core: Use avro compression properties from table properties when writing manifests and manifest lists

[via GitHub]

nastra commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1106886325


##########
core/src/main/java/org/apache/iceberg/ManifestWriter.java:
##########
@@ -64,7 +69,7 @@ private ManifestWriter(PartitionSpec spec, OutputFile file, 
Long snapshotId) {
   protected abstract ManifestEntry<F> prepare(ManifestEntry<F> entry);
 
   protected abstract FileAppender<ManifestEntry<F>> newAppender(
-      PartitionSpec spec, OutputFile outputFile);
+      PartitionSpec spec, OutputFile outputFile, String compressionCodec, 
Integer compressionLevel);

Review Comment:
   I believe it should be as I outlined in 
https://github.com/apache/iceberg/commit/1b237d570197d52fc0c7d959abc28ff14830d9aa.
 After one minor release we can then clean up the API.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org