rdblue commented on code in PR #6850:
URL: https://github.com/apache/iceberg/pull/6850#discussion_r1108757828
##########
core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java:
##########
@@ -18,17 +18,30 @@
*/
package org.apache.iceberg.rest;
+import java.util.Locale;
import java.util.Map;
import org.apache.iceberg.catalog.Namespace;
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.relocated.com.google.common.base.Joiner;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
public class ResourcePaths {
private static final Joiner SLASH = Joiner.on("/").skipNulls();
private static final String PREFIX = "prefix";
+ private static final String SNAPSHOT_LOADING_BEHAVIOR = "snapshot-loading";
Review Comment:
Why was this added to `ResourcePaths`? It seems like a separate concern and
it's confusing when I see calls like `paths.snapshotLoading()`. Why not just
handle params to the table load path separately?
This is also a public class and if we intend to change how this works (by
adding a snapshots route later) then we'll need to unwind this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
