[GitHub] [iceberg] wypoon commented on a diff in pull request #6799: Core: Use avro compression properties from table properties when writing manifests and manifest lists

[via GitHub]

wypoon commented on code in PR #6799:
URL: https://github.com/apache/iceberg/pull/6799#discussion_r1108812573


##########
.palantir/revapi.yml:
##########
@@ -261,6 +261,16 @@ acceptedBreaks:
         \ T) throws java.io.IOException, 
com.fasterxml.jackson.core.JacksonException\
         \ @ 
org.apache.iceberg.rest.RESTSerializers.UpdateRequirementDeserializer"
       justification: "False positive - JacksonException is a subclass of 
IOException"
+    - code: "java.method.numberOfParametersChanged"
+      old: "method 
org.apache.iceberg.io.FileAppender<org.apache.iceberg.ManifestEntry<F>>\
+        \ org.apache.iceberg.ManifestWriter<F extends 
org.apache.iceberg.ContentFile<F\
+        \ extends 
org.apache.iceberg.ContentFile<F>>>::newAppender(org.apache.iceberg.PartitionSpec,\
+        \ org.apache.iceberg.io.OutputFile)"
+      new: "method 
org.apache.iceberg.io.FileAppender<org.apache.iceberg.ManifestEntry<F>>\
+        \ org.apache.iceberg.ManifestWriter<F extends 
org.apache.iceberg.ContentFile<F\
+        \ extends 
org.apache.iceberg.ContentFile<F>>>::newAppender(org.apache.iceberg.PartitionSpec,\
+        \ org.apache.iceberg.io.OutputFile, java.lang.String, 
java.lang.Integer)"

Review Comment:
   I fail to see how that helps:
   ```
     protected FileAppender<ManifestEntry<F>> newAppender(
         PartitionSpec spec,
         OutputFile outputFile,
         String compressionCodec,
         Integer compressionLevel) {
       return newAppender(spec, outputFile);
     }
   ```
   We want to remove the `newAppender` with two parameters in the future 
release, at which time the above has to be changed. We really want to make it 
abstract. At that point, we will have a revapi breakage, wouldn't we? I fail to 
see how we can avoid the revapi breakage.
   @rdblue @danielcweeks ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org