rdblue commented on code in PR #6837:
URL: https://github.com/apache/iceberg/pull/6837#discussion_r1109146463
##########
aws/src/main/java/org/apache/iceberg/aws/s3/signer/S3V4RestSignerClient.java:
##########
@@ -105,6 +106,14 @@ public String token() {
return properties().get(OAuth2Properties.TOKEN);
}
+ @Value.Lazy
+ boolean refreshAuthByDefault() {
+ return PropertyUtil.propertyAsBoolean(
+ properties(),
+ CatalogProperties.AUTH_DEFAULT_REFRESH_ENABLED,
+ CatalogProperties.AUTH_DEFAULT_REFRESH_ENABLED_DEFAULT);
Review Comment:
If that property is confusing, then let's deprecate and remove it. I agree
that its behavior is surprising, but that doesn't mean we should increase
confusion by reusing it in other places. The simplest solution to make it more
clear is to remove it and rely just on the token expiration property. Then we
can add a property for what you actually want to control in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
