danielcweeks commented on code in PR #6850:
URL: https://github.com/apache/iceberg/pull/6850#discussion_r1110056420
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -263,9 +264,11 @@ public void renameTable(SessionContext context,
TableIdentifier from, TableIdent
client.post(paths.rename(), request, null, headers(context),
ErrorHandlers.tableErrorHandler());
}
- private LoadTableResponse loadInternal(SessionContext context,
TableIdentifier identifier) {
+ private LoadTableResponse loadInternal(
+ SessionContext context, TableIdentifier identifier, SnapshotLoading
snapshotLoading) {
Review Comment:
While we can control this at a catalog level (i.e. to set the default
behavior), but we need to change the method signature so that we can [override
the behavior when lazy
loading](https://github.com/apache/iceberg/pull/6850/files#diff-86450612dbe323d6d06cbc3846aa1913f042eaedadc0ca027c36bfbe08d3a46cR315).
We would either need a new method to load refs/all or pass in the option like
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
