nastra commented on code in PR #6850:
URL: https://github.com/apache/iceberg/pull/6850#discussion_r1110254859
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -279,7 +282,7 @@ public Table loadTable(SessionContext context,
TableIdentifier identifier) {
LoadTableResponse response;
TableIdentifier loadedIdent;
try {
- response = loadInternal(context, identifier);
+ response = loadInternal(context, identifier, paths.snapshotLoading());
Review Comment:
I constantly keep thinking that we're passing an actual path here because of
`paths`, while it's actually an enum. Would be great if we could make this more
obvious that it's not a path. Maybe we can move the enum to a different place?
##########
core/src/main/java/org/apache/iceberg/rest/ResourcePaths.java:
##########
@@ -18,17 +18,30 @@
*/
package org.apache.iceberg.rest;
+import java.util.Locale;
import java.util.Map;
import org.apache.iceberg.catalog.Namespace;
import org.apache.iceberg.catalog.TableIdentifier;
import org.apache.iceberg.relocated.com.google.common.base.Joiner;
+import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
public class ResourcePaths {
private static final Joiner SLASH = Joiner.on("/").skipNulls();
private static final String PREFIX = "prefix";
+ private static final String SNAPSHOT_LOADING_BEHAVIOR = "snapshot-loading";
Review Comment:
I agree that it's confusing seeing `paths.snapshotLoading()` calls in
`RESTSessionCatalog`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
