hililiwei commented on code in PR #6160:
URL: https://github.com/apache/iceberg/pull/6160#discussion_r1111387968
##########
flink/v1.16/flink/src/main/java/org/apache/iceberg/flink/FlinkConfigOptions.java:
##########
@@ -94,14 +94,17 @@ private FlinkConfigOptions() {}
public static final ConfigOption<SplitAssignerType>
TABLE_EXEC_SPLIT_ASSIGNER_TYPE =
ConfigOptions.key("table.exec.iceberg.split-assigner-type")
.enumType(SplitAssignerType.class)
- .defaultValue(SplitAssignerType.SIMPLE)
+ .noDefaultValue()
Review Comment:
We cannot use the default value. When the user does not configure it, we
need it to be null, so that we can further determine whether locality inference
is supported by checking the I/O type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
