aokolnychyi commented on code in PR #6876:
URL: https://github.com/apache/iceberg/pull/6876#discussion_r1113625944
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeltaWrite.java:
##########
@@ -241,17 +232,31 @@ private Expression
conflictDetectionFilter(SparkBatchQueryScan queryScan) {
@Override
public void abort(WriterCommitMessage[] messages) {
- if (!cleanupOnAbort) {
- return;
+ if (cleanupOnAbort) {
+ SparkCleanupUtil.deletePaths("job abort", table.io(),
filePaths(messages));
+ } else {
+ LOG.warn("Skipping cleanup of written files, unable to determine the
final commit state");
Review Comment:
I adapted the original comment but I agree it is a bit weird as the var name
is generic and does not say anything about commit state. I changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
