danielcweeks commented on code in PR #6887:
URL: https://github.com/apache/iceberg/pull/6887#discussion_r1114844324
##########
api/src/main/java/org/apache/iceberg/Files.java:
##########
@@ -57,7 +57,7 @@ public PositionOutputStream create() {
}
if (!file.getParentFile().isDirectory() &&
!file.getParentFile().mkdirs()) {
Review Comment:
Maybe we could just remove these checks. I feel like this is pretty bad
error handling since we check two different conditions and don't report which
or why we couldn't create the directory.
What if instead we just allowed the underlying exception to propagate up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
