aokolnychyi commented on code in PR #6899:
URL: https://github.com/apache/iceberg/pull/6899#discussion_r1114872889
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkTable.java:
##########
@@ -274,18 +275,21 @@ public boolean canDeleteWhere(Filter[] filters) {
}
}
- return deleteExpr == Expressions.alwaysTrue() ||
canDeleteUsingMetadata(deleteExpr);
+ return selectsPartitions(deleteExpr) || canDeleteUsingMetadata(deleteExpr);
Review Comment:
I'd keep a simpler return statement in this case as the selects partition
call should be fairly cheap for a true literal. Previously, we wanted to avoid
planning in some obvious cases. The new check should be instant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
