ajantha-bhat commented on PR #6789: URL: https://github.com/apache/iceberg/pull/6789#issuecomment-1446045524
@snazy, @dimas-b: I checked some more code today. **I found that `NessieTableOperation` works on a copy of the client. Not the actual client from `NessieCatalog`. as `withReference` creates a new client object.** https://github.com/apache/iceberg/blob/master/nessie/src/main/java/org/apache/iceberg/nessie/NessieCatalog.java#L197 And the client inside the `NessieTableOperation` will never be refreshed/out of state. There is also this check. https://github.com/apache/iceberg/blob/cb612ed142b600a7a4c8bb756fb71ffa5c1a0909/core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java#L121 TLDR; PR changes are for the client of `NessieCatalog`, not for the client of `NessieTableOperations`. Hence, I don't think there is any impact on the expected hash calculation of the commits of `NessieTableOperations`. Please recheck the PR again and let me know if a change required on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
