amogh-jahagirdar commented on code in PR #6650:
URL: https://github.com/apache/iceberg/pull/6650#discussion_r1120746475
##########
core/src/test/java/org/apache/iceberg/TestOverwrite.java:
##########
@@ -182,16 +182,16 @@ public void testOverwriteFailsDelete() {
@Test
public void testOverwriteWithAppendOutsideOfDelete() {
TableMetadata base = TestTables.readMetadata(TABLE_NAME);
- long baseId =
- latestSnapshot(base, branch) == null ? -1 : latestSnapshot(base,
branch).snapshotId();
+ Snapshot latestSnapshot = latestSnapshot(base, branch);
Review Comment:
We don't need to handle in this PR but given #6651 we will end up using the
SnapshotUtil api which is introduced. We can either update this PR with the
proposed utility API or just later refactor to use the utility API. Since this
is a test class, I'm okay either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
