jackye1995 commented on code in PR #6861:
URL: https://github.com/apache/iceberg/pull/6861#discussion_r1120853227


##########
api/src/main/java/org/apache/iceberg/view/ViewVersion.java:
##########
@@ -43,8 +47,7 @@ public interface ViewVersion {
   long timestampMillis();
 
   /**
-   * Return the version summary such as the name of the operation that created 
that version of the
-   * view
+   * Return a string map of summary data for the operation that produced this 
view version.

Review Comment:
   I think we can avoid having a change of spec here, the information in 
summary are just FYI purpose, I don't think we need to assign a semantic 
meaning to operations now, we can always add later if it becomes necessary. But 
for views I don't see anything other than CREATE and REPLACE, but it can also 
be identified directly through the version ID, ID=1 means CREATE, everything 
else are REPLACE.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to