fqaiser94 commented on code in PR #6513:
URL: https://github.com/apache/iceberg/pull/6513#discussion_r1120857513
##########
core/src/main/java/org/apache/iceberg/BaseOverwriteFiles.java:
##########
@@ -165,4 +165,9 @@ private Expression dataConflictDetectionFilter() {
return Expressions.alwaysTrue();
}
}
+
+ @Override
+ protected SnapshotUpdate<OverwriteFiles> returnThis() {
Review Comment:
This was a little tricky but I have managed to convince Java's type system
that `self` and `returnThis` have the same return type, so we no longer need to
specify a `returnThis` method for `SnapshotProducer` inheritors and in fact I
can rename the `returnThis` method to just `self` without any type conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
