jackye1995 commented on code in PR #5888:
URL: https://github.com/apache/iceberg/pull/5888#discussion_r1120907547
##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -199,6 +201,8 @@ protected void validate(TableMetadata currentMetadata,
Snapshot snapshot) {}
*/
protected abstract List<ManifestFile> apply(TableMetadata metadataToUpdate,
Snapshot snapshot);
+ protected abstract Long startingSnapshotId();
Review Comment:
I think this has to be non null? For the cases which it is currently null,
it's just because the value is missing. But we always know what is the starting
snapshot ID of the commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
