cccs-eric commented on PR #6970: URL: https://github.com/apache/iceberg/pull/6970#issuecomment-1450109465
Thanks for pointing this out @Fokko . IMHO, if we are going to list `connection-string` as an ADLS options in Iceberg's documentation, maybe we should add some more details about it. There is a catch with this one since it will overwrite other values like `account-name` (see https://github.com/fsspec/adlfs/blob/f15c37a43afd87a04f01b61cd90294dd57181e1d/adlfs/spec.py#L350-L354). So a user could be mislead by configuring both `connection-string` and `account-name` with different values. If I'm right, conftest.py could be changed to only configure `connection-string`. Not sure if we should copy AzureBlobFileSystem's doc over here, or simply link to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
