syun64 commented on code in PR #6980:
URL: https://github.com/apache/iceberg/pull/6980#discussion_r1123664500
##########
spark/v3.3/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestMetadataTables.java:
##########
@@ -488,6 +493,60 @@ public void testMetadataLogEntries() throws Exception {
metadataLogWithProjection);
}
+ @Test
Review Comment:
Haha, hmmm - I'd argue that the first one is more descriptive of the problem
and better describes the motivation in having the specific test, even though
it's longer... testFilesTimeTravelAddedColumn is a lot more literal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
