ajantha-bhat commented on code in PR #6661:
URL: https://github.com/apache/iceberg/pull/6661#discussion_r1124002815
##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -220,21 +251,53 @@ Iterable<Partition> all() {
static class Partition {
private final StructLike key;
- private long recordCount;
- private int fileCount;
private int specId;
+ private long dataRecordCount;
+ private int dataFileCount;
+
+ private final Set<DeleteFile> equalityDeleteFiles;
+ private final Set<DeleteFile> positionDeleteFiles;
Review Comment:
The same delete file object from the context is reused while making the
fileScan here.
https://github.com/apache/iceberg/blob/d42d1e89c0616c203f7ad29f002811ddd440e14f/core/src/main/java/org/apache/iceberg/ManifestGroup.java#L351
hence, I believe the default equals() is enough.
I don't disagree about having the equals and hashcode for `DataFiles` and
`DeleteFiles`. But code is widely using the `Set<DataFile>` and
`Set<DeleteFile>` already. So, if we are adding it. It should be in a separate
PR/discussion.
Let us see what others think on this.
cc: @RussellSpitzer, @jackye1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
