Fokko commented on code in PR #6970:
URL: https://github.com/apache/iceberg/pull/6970#discussion_r1124957788
##########
python/tests/conftest.py:
##########
@@ -1277,8 +1277,8 @@ def adlfs_fsspec_fileio(request: pytest.FixtureRequest)
-> Generator[FsspecFileI
azurite_account_key = request.config.getoption("--adlfs.account-key")
azurite_connection_string =
f"DefaultEndpointsProtocol=http;AccountName={azurite_account_name};AccountKey={azurite_account_key};BlobEndpoint={azurite_url}/{azurite_account_name};"
properties = {
- "connection_string": azurite_connection_string,
- "account_name": azurite_account_name,
+ "adlfs.connection-string": azurite_connection_string,
+ "adlfs.account-name": azurite_account_name,
Review Comment:
Thanks for the responses @alaturqua and @cccs-eric
> The implementation could check and force to use one of them either
connection-string or account-name + accunt-key.
This is also how it originally was intended, I'm all for it.
> For the Azure Storage URL's there are following possibilites. I guess this
is for the other PR relevant.
I've added those, did you have a chance of testing these?
> I don't know what is Iceberg philosophy when it comes to using an external
library, i.e. should Iceberg retain full control or delegation is fine?
We are liberal in the options that we accept, but we want to unify them. For
example, for S3 there are two FileIO's, PyArrow and S3FS. You can switch
between them without having to change your configuration. Therefore we have to
do some mapping between the names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
