danielcweeks commented on code in PR #6951: URL: https://github.com/apache/iceberg/pull/6951#discussion_r1125129463
########## aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java: ########## @@ -628,6 +630,43 @@ public class AwsProperties implements Serializable { */ public static final String LAKE_FORMATION_DB_NAME = "lakeformation.db-name"; + /** Region to be used by the SigV4 protocol for signing requests. */ + public static final String REST_SIGV4_SIGNER_REGION = "rest.sigv4.signing-region"; + + /** The service name to be used by the SigV4 protocol for signing requests. */ + public static final String REST_SIGV4_SIGNING_NAME = "rest.sigv4.signing-name"; + + /** The default service name (API Gateway and lambda) used during SigV4 signing. */ + public static final String REST_SIGV4_SIGNING_NAME_DEFAULT = "execute-api"; Review Comment: This is the default value, not a property that can be set. The `execute-api` is used for api gateway and lambdas as the service name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org