JonasJ-ap commented on code in PR #6997: URL: https://github.com/apache/iceberg/pull/6997#discussion_r1125299771
########## python/pyiceberg/io/pyarrow.py: ########## @@ -476,6 +483,217 @@ def expression_to_pyarrow(expr: BooleanExpression) -> pc.Expression: return boolean_expression_visit(expr, _ConvertToArrowExpression()) +def pyarrow_to_schema(schema: pa.Schema) -> Schema: Review Comment: Thank you for your suggestions. I did not realize that `pa.DataType` can be used to to catch all the primitives. I refactored the visitor to take advantage of the `singledispatch`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org