rdblue commented on code in PR #6844:
URL: https://github.com/apache/iceberg/pull/6844#discussion_r1125743873
##########
python/pyiceberg/io/__init__.py:
##########
@@ -275,21 +276,22 @@ def _import_file_io(io_impl: str, properties: Properties)
-> Optional[FileIO]:
class_ = getattr(module, class_name)
return class_(properties)
except ModuleNotFoundError:
- logger.warning("Could not initialize FileIO: %s", io_impl)
+ warnings.warn(f"Could not initialize FileIO: {io_impl}")
Review Comment:
Why go through `warnings` instead of the logger? (Not a blocker, I want to
know when to use one or the other)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
