rdblue commented on code in PR #6992:
URL: https://github.com/apache/iceberg/pull/6992#discussion_r1125756552
##########
spark/v3.1/spark/src/main/java/org/apache/iceberg/spark/procedures/ExpireSnapshotsProcedure.java:
##########
@@ -52,7 +52,8 @@ public class ExpireSnapshotsProcedure extends BaseProcedure {
ProcedureParameter.optional("older_than", DataTypes.TimestampType),
ProcedureParameter.optional("retain_last", DataTypes.IntegerType),
ProcedureParameter.optional("max_concurrent_deletes",
DataTypes.IntegerType),
- ProcedureParameter.optional("stream_results", DataTypes.BooleanType)
+ ProcedureParameter.optional("stream_results", DataTypes.BooleanType),
+ ProcedureParameter.optional("snapshot_ids",
DataTypes.createArrayType(DataTypes.LongType))
Review Comment:
Looks like the parser can't actually handle nulls, so this is actually okay.
I get a parser error when I try to test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
