nastra commented on code in PR #6984:
URL: https://github.com/apache/iceberg/pull/6984#discussion_r1128267737
##########
core/src/test/java/org/apache/iceberg/TestSortOrder.java:
##########
@@ -320,6 +320,9 @@ public void testColumnDropWithSortOrder() {
"Order ID must match", TableMetadata.INITIAL_SORT_ORDER_ID + 1,
actualOrder.orderId());
Assert.assertEquals(
"Schema must have one less column", initialColSize - 1,
table.schema().columns().size());
+
+ // ensure that the table metadata can be serialized and reloaded with an
invalid order
+
TableMetadataParser.fromJson(TableMetadataParser.toJson(table.ops().current()));
Review Comment:
nit: generally speaking I think we should have an assertion here, even if we
only want to make sure that code doesn't fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
