rdblue commented on code in PR #7035:
URL: https://github.com/apache/iceberg/pull/7035#discussion_r1128779435
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -176,15 +176,16 @@ public void initialize(String name, Map<String, String>
unresolved) {
this.client = clientBuilder.apply(mergedProps);
this.paths = ResourcePaths.forCatalogProperties(mergedProps);
+ String token = mergedProps.get(OAuth2Properties.TOKEN);
Review Comment:
I think we want to use the `initToken` if no token was sent back. That
should be what happens here since it was pulled from the original properties,
but it isn't obvious and I think you can remove properties in the config route.
What about using `getOrDefault(TOKEN, initToken)` to make it clear?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
