szehon-ho commented on code in PR #7029:
URL: https://github.com/apache/iceberg/pull/7029#discussion_r1129014586
##########
core/src/main/java/org/apache/iceberg/io/DeleteSchemaUtil.java:
##########
@@ -29,7 +29,7 @@ private static Schema pathPosSchema(Schema rowSchema) {
return new Schema(
MetadataColumns.DELETE_FILE_PATH,
MetadataColumns.DELETE_FILE_POS,
- Types.NestedField.required(
+ Types.NestedField.optional(
Review Comment:
I updated the pr with a fix for this , the idea from chatting with
@RussellSpitzer offline. I made SparkWrite.DeleteWriter now a fan-out that can
redirect deletes to two files, one that either has 'row' as required struct, or
no 'row' at all. In most case only one will be chosen. Thanks for the initial
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
