jackye1995 commented on code in PR #6965:
URL: https://github.com/apache/iceberg/pull/6965#discussion_r1129075295
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -83,7 +91,11 @@ public Long endSnapshotId() {
}
public String branch() {
- return
confParser.stringConf().option(SparkReadOptions.BRANCH).parseOptional();
+ String optionBranch =
confParser.stringConf().option(SparkReadOptions.BRANCH).parseOptional();
+ ValidationException.check(
Review Comment:
This check ensures that we discourage the use of read option to avoid
further confusion. Technically we can allow this when the option branch and
identifier branch are the same, but that is discouraged anyway so I decided to
block them all together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
