fqaiser94 commented on code in PR #6513:
URL: https://github.com/apache/iceberg/pull/6513#discussion_r1130247837
##########
.palantir/revapi.yml:
##########
@@ -261,6 +266,17 @@ acceptedBreaks:
\ T) throws java.io.IOException,
com.fasterxml.jackson.core.JacksonException\
\ @
org.apache.iceberg.rest.RESTSerializers.UpdateRequirementDeserializer"
justification: "False positive - JacksonException is a subclass of
IOException"
+ - code: "java.method.numberOfParametersChanged"
+ old: "method void
org.apache.iceberg.SetLocation::<init>(org.apache.iceberg.TableOperations)"
+ new: "method void
org.apache.iceberg.SetLocation::<init>(java.lang.String,
org.apache.iceberg.TableOperations)"
+ justification: "SetLocation should only be constructed by Iceberg code.
Hence\
+ \ the change of constructor params shouldn't affect users."
+ - code: "java.method.numberOfParametersChanged"
+ old: "method void
org.apache.iceberg.SetStatistics::<init>(org.apache.iceberg.TableOperations)"
+ new: "method void
org.apache.iceberg.SetStatistics::<init>(java.lang.String,\
+ \ org.apache.iceberg.TableOperations)"
+ justification: "SetStatistics should only be constructed by Iceberg
code. Hence\
+ \ the change of constructor params shouldn't affect users."
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
