rdblue commented on code in PR #7049:
URL: https://github.com/apache/iceberg/pull/7049#discussion_r1131319047
##########
.palantir/revapi.yml:
##########
@@ -67,9 +67,45 @@ acceptedBreaks:
justification: "Removing deprecated method"
"1.1.0":
org.apache.iceberg:iceberg-core:
+ - code: "java.class.noLongerImplementsInterface"
+ old: "class org.apache.iceberg.jdbc.JdbcCatalog"
+ new: "class org.apache.iceberg.jdbc.JdbcCatalog"
+ justification: "Needed to remove compilation dependency on Hadoop"
Review Comment:
Since the `setConf(Configuration)` methods are public, I don't think that we
can make this change directly. I think we need to add `setConf(Object)` and
update to `Configurable<Object>` but leave the `setConf(Configuration)` and
deprecate it so we can remove it in 1.3.
That aligns with our published guarantees about compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
