nastra commented on code in PR #7064:
URL: https://github.com/apache/iceberg/pull/7064#discussion_r1132081630
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -762,16 +765,25 @@ private String fullTableName(TableIdentifier ident) {
return String.format("%s.%s", name(), ident);
}
+ private FileIO newFileIO(Map<String, String> properties) {
+ if (null != ioBuilder) {
+ return ioBuilder.apply(properties);
+ } else {
+ String ioImpl = properties.get(CatalogProperties.FILE_IO_IMPL);
+ return
+ CatalogUtil.loadFileIO(
+ ioImpl != null ? ioImpl : ResolvingFileIO.class.getName(),
properties, conf);
Review Comment:
nit: maybe worth inlining this, so that we don't need the null check on
`ioImpl`:
```
CatalogUtil.loadFileIO(
properties.getOrDefault(CatalogProperties.FILE_IO_IMPL,
ResolvingFileIO.class.getName()),
properties,
conf);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
