stevenzwu commented on code in PR #7070:
URL: https://github.com/apache/iceberg/pull/7070#discussion_r1132942620
##########
docs/flink-getting-started.md:
##########
@@ -687,11 +664,11 @@ FlinkSink.forRowData(input)
env.execute("Test Iceberg DataStream");
```
-The iceberg API also allows users to write generic `DataStream<T>` to iceberg
table, more example could be found in this [unit
test](https://github.com/apache/iceberg/blob/master/flink/v1.15/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java).
+The iceberg API also allows users to write generic `DataStream<T>` to iceberg
table, more example could be found in this [unit
test](https://github.com/apache/iceberg/blob/master/flink/v1.16/flink/src/test/java/org/apache/iceberg/flink/sink/TestFlinkIcebergSink.java).
### Overwrite data
-To overwrite the data in existing iceberg table dynamically, we could set the
`overwrite` flag in FlinkSink builder.
+To overwrite the data in existing iceberg table dynamically, set the
`overwrite` flag in FlinkSink builder.
Review Comment:
is this a complete sentence? seems missing noun :) Maybe reverse the order
like you did in some other places. `Set the overwrite flag ... to overwrite
data in the existing partitions.`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]