jackye1995 commented on code in PR #7050:
URL: https://github.com/apache/iceberg/pull/7050#discussion_r1133037748
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java:
##########
@@ -937,6 +938,28 @@ public static
org.apache.spark.sql.catalyst.TableIdentifier toV1TableIdentifier(
return org.apache.spark.sql.catalyst.TableIdentifier.apply(table,
database);
}
+ public static String determineWriteBranch(
Review Comment:
This method can technically be embedded in `SparkWriteConf.branch()`. If we
do that, we can also remove `SparkWriteConf.wapBranch()`. The only issue is
that it will compute `wapId` and `wapEnabled` twice, once in the method, once
in `SparkWrite`/`SparkPositionDeltaWrite`. Please let me know if there is any
preference for code cleanness vs computation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
