rdblue commented on code in PR #6762:
URL: https://github.com/apache/iceberg/pull/6762#discussion_r1133148100
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkAppenderFactory.java:
##########
@@ -161,29 +164,37 @@ private StructType lazyPosDeleteSparkType() {
}
@Override
- public FileAppender<InternalRow> newAppender(OutputFile file, FileFormat
fileFormat) {
+ public FileAppender<InternalRow> newAppender(OutputFile outputFile,
FileFormat format) {
+ return newAppender(
+ EncryptedFiles.encryptedOutput(outputFile, (EncryptionKeyMetadata)
null), format);
Review Comment:
Can you add a pass-through factory method to `EncryptedFiles` rather than
constructing one here? I think it would be better to call
`EncryptedFiles.plainAsEncryptedOutput` rather than passing null key metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
