RussellSpitzer commented on code in PR #6886:
URL: https://github.com/apache/iceberg/pull/6886#discussion_r1136050274
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkCatalog.java:
##########
@@ -132,6 +134,14 @@ protected Catalog buildIcebergCatalog(String name,
CaseInsensitiveStringMap opti
optionsMap.putAll(options.asCaseSensitiveMap());
optionsMap.put(CatalogProperties.APP_ID,
SparkSession.active().sparkContext().applicationId());
optionsMap.put(CatalogProperties.USER,
SparkSession.active().sparkContext().sparkUser());
+ // if spark.sql.catalog.$catalogName.warehouse no setting, will try use
+ // spark.sql.warehouse.dir as catalog warehouse.
+ final String warehouse =
+ Optional.ofNullable(conf.get(CatalogProperties.WAREHOUSE_LOCATION))
+ .orElseGet(() ->
optionsMap.get(StaticSQLConf.WAREHOUSE_PATH().key()));
Review Comment:
I don't believe this would be in the options map, would it be in the sql
conf?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
