aokolnychyi commented on code in PR #7050:
URL: https://github.com/apache/iceberg/pull/7050#discussion_r1136504884
##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/SparkReadConf.java:
##########
@@ -98,7 +98,22 @@ public String branch() {
+ "got [%s] in identifier and [%s] in options",
branch,
optionBranch);
- return branch != null ? branch : optionBranch;
+ String inputBranch = branch != null ? branch : optionBranch;
+ if (inputBranch != null) {
+ return inputBranch;
+ }
+
+ boolean wapEnabled =
Review Comment:
nit: I'd prefer a separate method called `wapEnabled()` like we have in
SparkWriteConf. Then we could use the constant for the default value and it
would simplify this method.
```
public boolean wapEnabled() {
return confParser
.booleanConf()
.tableProperty(TableProperties.WRITE_AUDIT_PUBLISH_ENABLED)
.defaultValue(TableProperties.WRITE_AUDIT_PUBLISH_ENABLED_DEFAULT)
.parse();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
