Fokko commented on code in PR #6398:
URL: https://github.com/apache/iceberg/pull/6398#discussion_r1137324576
##########
python/pyiceberg/io/pyarrow.py:
##########
@@ -428,11 +428,11 @@ def visit_not_in(self, term: BoundTerm[pc.Expression],
literals: Set[Any]) -> pc
def visit_is_nan(self, term: BoundTerm[Any]) -> pc.Expression:
ref = pc.field(term.ref().field.name)
- return ref.is_null(nan_is_null=True) & ref.is_valid()
+ return pc.is_nan(ref)
Review Comment:
This is actually to make the CI pass. I've [created a
PR](https://github.com/apache/arrow/pull/34184) to allow `ref.is_nan()` as
well, but this is not released yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
