stevenzwu commented on code in PR #7059:
URL: https://github.com/apache/iceberg/pull/7059#discussion_r1137850193
##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/IcebergTableSink.java:
##########
@@ -69,16 +73,20 @@ public SinkRuntimeProvider getSinkRuntimeProvider(Context
context) {
List<String> equalityColumns =
tableSchema.getPrimaryKey().map(UniqueConstraint::getColumns).orElseGet(ImmutableList::of);
- return (DataStreamSinkProvider)
Review Comment:
@Fokko I think it is still good to update code here. We should avoid using
lambda function since `DataStreamSinkProvider` is not annotated with
`@FunctionalInterface`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
