szehon-ho commented on PR #7029: URL: https://github.com/apache/iceberg/pull/7029#issuecomment-1472989189
Made suggested changes (refactored to new classe SparkPositionDeletesRewrite from SparkWrite). Notes, new classes drop some unused codes from the previous path, like reportMetrics method and cleanupOnAbort flag to control abort behavior. I assume we can go back to this when we implement the commit manager part, as of now its not clear whether we need this or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
