dpaani commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1140472712
##########
aws/src/test/java/org/apache/iceberg/aws/TestAwsClientFactories.java:
##########
@@ -132,6 +136,41 @@ public void
testLakeFormationAwsClientFactorySerializable() throws IOException {
.isInstanceOf(LakeFormationAwsClientFactory.class);
}
+ @Test
+ public void testDefaultAwsClientFactoryWithCredentialsProvider() {
+ Map<String, String> properties = Maps.newHashMap();
+ properties.put(AwsProperties.AWS_REGION, Region.AWS_GLOBAL.toString());
+ properties.put(
+ AwsProperties.S3FILEIO_CREDENTIALS_PROVIDER,
+ SystemPropertyCredentialsProvider.class.getName());
Review Comment:
Added check to make sure provider implements AwsCredentialsProvider
interface.
@jackye1995 It looks like DynMethods does not throw ClassNotFoundException
but DynClasses does. I replaced Class.forName with DynClasses.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
