wobrycki commented on issue #4581: URL: https://github.com/apache/iceberg/issues/4581#issuecomment-1476479898
@RussellSpitzer could you point us to the code, where the adjustments are needed? Should it be `SparkValueReaders.java` and `SparkValueWriters.java`? I guess there is no test that writes the UUID column as it is not working yet, so we should probably adjust the tests like `TestSparkParquetWriter` as well. Normally uuids(ColumnDescriptor desc) returns an instance of ValueWriter<UTF8String> and not PrimitiveWriter<UTF8String>, what is the reason we are going for PrimitiveWriter here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
