jackye1995 commented on code in PR #7066:
URL: https://github.com/apache/iceberg/pull/7066#discussion_r1142722097
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -645,6 +681,7 @@ public class AwsProperties implements Serializable {
private String s3AccessKeyId;
private String s3SecretAccessKey;
private String s3SessionToken;
+ private String credentialsProvider;
Review Comment:
nit: `clientCredentialsProvider`
##########
aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:
##########
@@ -678,6 +715,10 @@ public class AwsProperties implements Serializable {
private final String s3SignerImpl;
private final Map<String, String> allProperties;
+ private String clientRegion;
+
+ private final Map<String, String> credentialsProviderProperties;
Review Comment:
nit: `clientCredentialsProviderProperties`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
